Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix bitmap supported type #34350

Merged
merged 1 commit into from
Jul 5, 2024
Merged

fix: fix bitmap supported type #34350

merged 1 commit into from
Jul 5, 2024

Conversation

zhagnlu
Copy link
Collaborator

@zhagnlu zhagnlu commented Jul 2, 2024

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Jul 2, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Jul 2, 2024
@zhagnlu zhagnlu force-pushed the fix_bitmap_supported_type branch from c9e42bc to 4fd5a04 Compare July 2, 2024 10:03
@mergify Mergify
Copy link
Contributor

mergify bot commented Jul 2, 2024

@zhagnlu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@zhagnlu
Copy link
Collaborator Author

zhagnlu commented Jul 2, 2024

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Jul 2, 2024

@zhagnlu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

1 similar comment
@mergify Mergify
Copy link
Contributor

mergify bot commented Jul 3, 2024

@zhagnlu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@zhagnlu zhagnlu force-pushed the fix_bitmap_supported_type branch from 4fd5a04 to 475df7e Compare July 3, 2024 02:29
@mergify Mergify
Copy link
Contributor

mergify bot commented Jul 3, 2024

@zhagnlu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@codecov Codecov
Copy link

codecov bot commented Jul 3, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 92.30769% with 2 lines in your changes missing coverage. Please review.

Project coverage is 79.66%. Comparing base (96dcee5) to head (bae1991).
Report is 53 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #34350      +/-   ##
==========================================
- Coverage   80.84%   79.66%   -1.18%     
==========================================
  Files        1085     1114      +29     
  Lines      137510   138519    +1009     
==========================================
- Hits       111171   110355     -816     
- Misses      22114    23910    +1796     
- Partials     4225     4254      +29
Files Coverage Δ
internal/proxy/task_index.go 79.96% <ø> (+0.16%) ⬆️
pkg/util/indexparamcheck/base_checker.go 95.45% <ø> (+4.54%) ⬆️
...util/indexparamcheck/binary_vector_base_checker.go 100.00% <100.00%> (ø)
pkg/util/indexparamcheck/bitmap_index_checker.go 100.00% <100.00%> (ø)
.../util/indexparamcheck/float_vector_base_checker.go 100.00% <100.00%> (ø)
pkg/util/indexparamcheck/hnsw_checker.go 100.00% <100.00%> (ø)
pkg/util/indexparamcheck/inverted_checker.go 100.00% <100.00%> (ø)
pkg/util/indexparamcheck/stl_sort_checker.go 100.00% <100.00%> (ø)
pkg/util/indexparamcheck/trie_checker.go 100.00% <100.00%> (ø)
pkg/util/indexparamcheck/auto_index_checker.go 33.33% <0.00%> (ø)
... and 1 more

... and 266 files with indirect coverage changes

@zhagnlu
Copy link
Collaborator Author

zhagnlu commented Jul 3, 2024

/run-cpu-e2e

1 similar comment
@zhagnlu
Copy link
Collaborator Author

zhagnlu commented Jul 3, 2024

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Jul 3, 2024

@zhagnlu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@zhagnlu
Copy link
Collaborator Author

zhagnlu commented Jul 4, 2024

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Jul 4, 2024
@zhagnlu zhagnlu force-pushed the fix_bitmap_supported_type branch from 475df7e to 4ae31f2 Compare July 5, 2024 03:51
@mergify mergify bot removed the ci-passed label Jul 5, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Jul 5, 2024

@zhagnlu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

fix: fix bitmap supported type
bae1991 
Signed-off-by: luzhang <luzhang@zilliz.com>
@zhagnlu zhagnlu force-pushed the fix_bitmap_supported_type branch from 4ae31f2 to bae1991 Compare July 5, 2024 04:05
@mergify mergify bot added the ci-passed label Jul 5, 2024
@czs007
Copy link
Contributor

czs007 commented Jul 5, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, zhagnlu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 18f2458 into milvus-io:master Jul 5, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bigsheeper bigsheeper Awaiting requested review from bigsheeper

@godchen0212 godchen0212 Awaiting requested review from godchen0212

Assignees

@czs007 czs007

Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zhagnlu @czs007 @sre-ci-robot